Skip to content

add logs to cairo_run_program_with_initial_scope #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabrielbosio merged 1 commit into from
Feb 10, 2026
Merged

add logs to cairo_run_program_with_initial_scope #2319

gabrielbosio merged 1 commit into from
Feb 10, 2026

Conversation

@nitsan-starkware
Copy link
Collaborator

@nitsan-starkware nitsan-starkware commented Feb 8, 2026 •
edited
Loading

This change is Reviewable

@nitsan-starkware nitsan-starkware force-pushed the nitsan/add_logs_to_cairo_run_program_with_initial_scope branch from 5354b1b to f05e46d Compare February 8, 2026 09:27
@github-actions
Copy link

github-actions bot commented Feb 8, 2026 •
edited
Loading 

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     23.010 s ±  0.044 s    [User: 22.127 s, System: 0.879 s]
  Range (min … max):   22.978 s … 23.041 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     23.222 s ±  0.011 s    [User: 22.369 s, System: 0.850 s]
  Range (min … max):   23.214 s … 23.230 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     12.343 s ±  0.005 s    [User: 22.137 s, System: 0.879 s]
  Range (min … max):   12.340 s … 12.347 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     12.528 s ±  0.012 s    [User: 22.540 s, System: 0.865 s]
  Range (min … max):   12.520 s … 12.536 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.688 s ±  0.068 s    [User: 35.285 s, System: 1.103 s]
  Range (min … max):    9.639 s …  9.736 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.029 s ±  0.192 s    [User: 34.799 s, System: 1.065 s]
  Range (min … max):    9.894 s … 10.165 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.04 ± 0.02 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.717 s ±  0.013 s    [User: 35.386 s, System: 1.092 s]
  Range (min … max):    9.708 s …  9.726 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.778 s ±  0.217 s    [User: 34.925 s, System: 1.118 s]
  Range (min … max):    9.625 s …  9.932 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.563 s ±  0.016 s    [User: 35.927 s, System: 1.121 s]
  Range (min … max):    9.552 s …  9.575 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.557 s ±  0.179 s    [User: 35.580 s, System: 1.150 s]
  Range (min … max):    9.431 s …  9.684 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.00 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.925 s ±  0.006 s    [User: 35.916 s, System: 1.229 s]
  Range (min … max):    9.920 s …  9.929 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.619 s ±  0.086 s    [User: 35.673 s, System: 1.214 s]
  Range (min … max):    9.558 s …  9.680 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.03 ± 0.01 times faster than hyper_threading_main threads: 16

@github-actions
Copy link

github-actions bot commented Feb 8, 2026 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.234 ± 0.004 2.227 2.241 1.03 ± 0.01
head big_factorial 2.169 ± 0.016 2.154 2.206 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.160 ± 0.005 2.152 2.166 1.04 ± 0.00
head big_fibonacci 2.085 ± 0.005 2.079 2.092 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.814 ± 0.104 7.713 7.974 1.06 ± 0.02
head blake2s_integration_benchmark 7.361 ± 0.118 7.251 7.566 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.307 ± 0.022 2.285 2.355 1.03 ± 0.01
head compare_arrays_200000 2.236 ± 0.008 2.224 2.251 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.486 ± 0.004 1.481 1.495 1.01 ± 0.00
head dict_integration_benchmark 1.470 ± 0.003 1.466 1.476 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.267 ± 0.009 1.260 1.287 1.03 ± 0.02
head field_arithmetic_get_square_benchmark 1.230 ± 0.016 1.218 1.275 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.866 ± 0.014 7.845 7.884 1.06 ± 0.01
head integration_builtins 7.408 ± 0.035 7.359 7.482 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.884 ± 0.009 7.873 7.901 1.06 ± 0.01
head keccak_integration_benchmark 7.444 ± 0.037 7.394 7.526 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.280 ± 0.007 2.267 2.290 1.03 ± 0.01
head linear_search 2.210 ± 0.018 2.195 2.259 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.574 ± 0.005 1.566 1.584 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.553 ± 0.007 1.547 1.572 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.530 ± 0.007 1.520 1.542 1.02 ± 0.01
head math_integration_benchmark 1.502 ± 0.005 1.495 1.509 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.285 ± 0.004 1.279 1.291 1.02 ± 0.01
head memory_integration_benchmark 1.259 ± 0.009 1.251 1.282 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.613 ± 0.010 1.605 1.636 1.02 ± 0.01
head operations_with_data_structures_benchmarks 1.575 ± 0.005 1.570 1.587 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 543.4 ± 1.2 542.3 545.6 1.01 ± 0.01
head pedersen 536.2 ± 4.1 533.1 547.3 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 620.9 ± 1.9 617.7 623.8 1.00 ± 0.01
head poseidon_integration_benchmark 618.7 ± 4.0 613.7 625.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.859 ± 0.017 1.845 1.901 1.02 ± 0.01
head secp_integration_benchmark 1.827 ± 0.005 1.821 1.836 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 685.5 ± 2.1 682.5 689.1 1.00
head set_integration_benchmark 686.5 ± 2.5 684.2 693.0 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.408 ± 0.031 4.382 4.490 1.04 ± 0.01
head uint256_integration_benchmark 4.220 ± 0.016 4.196 4.252 1.00

@nitsan-starkware nitsan-starkware force-pushed the nitsan/add_logs_to_cairo_run_program_with_initial_scope branch from f05e46d to 8a16b3c Compare February 8, 2026 10:06
@codecov
Copy link

codecov bot commented Feb 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.99%. Comparing base (5b3c94a) to head (95be27d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2319   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         104      104           
  Lines       36995    37011   +16     
=======================================
+ Hits        35514    35530   +16     
  Misses       1481     1481

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nitsan-starkware nitsan-starkware force-pushed the nitsan/add_logs_to_cairo_run_program_with_initial_scope branch from 8a16b3c to 95be27d Compare February 8, 2026 12:42
YairVaknin-starkware
YairVaknin-starkware approved these changes Feb 10, 2026
View reviewed changes
Copy link
Collaborator

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

These are nice high lvl logs, we might want to consider adding more robust debug coverage. Is this planned?

@YairVaknin-starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware).

@gabrielbosio gabrielbosio added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 7bbf8cd Feb 10, 2026
95 checks passed
@gabrielbosio gabrielbosio deleted the nitsan/add_logs_to_cairo_run_program_with_initial_scope branch February 10, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielbosio gabrielbosio gabrielbosio approved these changes

@YairVaknin-starkware YairVaknin-starkware YairVaknin-starkware approved these changes

@Yael-Starkware Yael-Starkware Awaiting requested review from Yael-Starkware

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitsan-starkware @gabrielbosio @YairVaknin-starkware